Repository navigation
feat: refresh the / Skill menu live while a conversation is open - #4264
DoodleBears wants to merge 6 commits into
Conversation
Issue: #4234 Agent-Task: codex/local/01a1e105-c85e-73a3-a607-dbb8007b9911
Subscribe to Skill catalog changes for the open conversation and refetch the catalog on each change, keeping only the latest response. Issue: #4234 Agent-Task: claude-code/local/b7955cb7-65c2-4b41-bafd-b18256e4a38b Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
@coderabbitai review |
Action not completed
|
Bot-main tests build actions from a Proxy whose unknown members return a rejected promise; the live Skill catalog subscription needs a real unsubscribe function there. Issue: #4234 Agent-Task: claude-code/local/b7955cb7-65c2-4b41-bafd-b18256e4a38b Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@coderabbitai review |
Action not completed
|
#4234 | hub #4231 | stacked on #4259 | Agent tasks:
claude-code/local/b7955cb7-65c2-4b41-bafd-b18256e4a38b(Client, integration, review),codex/local/01a1e105-c85e-73a3-a607-dbb8007b9911(Host refresh, events)Closes #4234
Why the change
The
/menu read the Skill catalog once when a conversation opened, so a Skill added, edited or deleted while the DM or Group was open stayed invisible until the Human reopened it. S4 (PersonaBots install their own Skills) needs a newly written Skill to show up right away.Special things to note
mainafter those merge.skills/change, a no-op DSH Skill provider used only for itscontrol.invalidate(), and a new event on the existing roster SSE carrier.<memory>/.agents/skillsand<memory>/.dsh/skills(recursive, plus shallow parent watches for missing or replaced roots) and reconciles watchers on Bot create, delete, preset change and Memory move.skills-listuses the samechannelSkillCatalogRPC, so the CLI reads the same fresh catalog.installHostSkillInvalidationinnative-agent-compat.ts(it registers an empty provider to obtain DSH's public registry invalidation) and watcher cleanup inskills/refresh.ts.Change outline
Before: with Ada's DM open, typing
/demoshows nothing that matches.Add while open: writing
<memory>/.agents/skills/demo-live/SKILL.mdmakes/demo-liveappear in the same open menu about 3 s later, with no reload.Edit while open: changing its description updates the row in place.
Isolated Host, one headless browser session per capture that stays open while the file is written (
--wait-texton the new text), viewport 1440×900 cropped to the conversation pane, light theme, English.Tests:
packages/core/test/skill-catalog-refresh.test.ts(invalidation scope by registry call counts, add/modify/delete in both trees, Host change, Memory move, cleanup),packages/client/test/skill-catalog-live.test.ts(SSE parsing, channel filtering, reconnect baseline, unsubscribe). Codex ran 641ci-planaffected suites (7,151 tests) plus a DSH0.2.2-rc.1runtime probe for the delete case and.dsh/skills;pnpm lintandtscare clean on the integrated head. Delete-while-open was not captured in the browser:--wait-textcan only wait for text to appear, so the delete case rests on the runtime probe.🤖 Generated with Claude Code